Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated toolsClasspath targets in favor of uniquely named new ones #1475

Merged
merged 2 commits into from
Sep 16, 2021
Merged

Deprecated toolsClasspath targets in favor of uniquely named new ones #1475

merged 2 commits into from
Sep 16, 2021

Conversation

lefou
Copy link
Member

@lefou lefou commented Sep 15, 2021 •
edited
Loading

Fixes #916

@lefou lefou requested a review from lolgab September 15, 2021 20:43
lolgab
lolgab reviewed Sep 15, 2021
View reviewed changes
Copy link
Member

@lolgab lolgab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment on one name. Didn't review the rest yet tho.

scalajslib/src/ScalaJSModule.scala Outdated Show resolved Hide resolved
@lolgab
Copy link
Member

lolgab commented Sep 16, 2021

LGTM 👍

@lefou lefou merged commit 93bbb8d into com-lihaoyi:main Sep 16, 2021
@lefou lefou deleted the toolsClasspath branch September 16, 2021 09:03
@lefou lefou added this to the 0.10.0-M2 milestone Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolgab lolgab lolgab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.0-M2
Development

Successfully merging this pull request may close these issues.

toolsClasspath from ScalaJSModule and ScoverageModule conflict
2 participants
@lefou @lolgab